Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve assets perfs #12843

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

fix: improve assets perfs #12843

wants to merge 46 commits into from
+862 −523

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 7, 2025 •
edited
Loading

Description

Related issues

Fixes: #12679

Manual testing steps

  1. Build android project locally
  2. Add your account or create new one
  3. switch btw network ( the perfs should be good )
  4. switch btw popular network and current network on the token list and check the perfs
  5. the list of assets should be displayed quickly

Screenshots/Recordings

Before

After

Screen.Recording.2025-01-06.at.16.18.39.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0517725
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/60c941e8-a3af-45f8-9398-feb4210a03ef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb marked this pull request as ready for review January 8, 2025 16:59
@salimtb salimtb requested review from a team as code owners January 8, 2025 16:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.84314% with 86 lines in your changes missing coverage. Please review.

Project coverage is 59.78%. Comparing base (6b68dd7) to head (b29db02).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...onents/UI/Tokens/TokenList/TokenListItem/index.tsx 56.56% 23 Missing and 20 partials ⚠️
app/components/UI/AssetOverview/AssetOverview.tsx 0.00% 10 Missing ⚠️
app/components/UI/Tokens/index.tsx 70.00% 0 Missing and 9 partials ⚠️
...mponents/Views/NetworkSelector/NetworkSelector.tsx 71.87% 8 Missing and 1 partial ⚠️
app/components/UI/NetworkModal/index.tsx 33.33% 6 Missing ⚠️
...nnectMultiSelector/NetworkConnectMultiSelector.tsx 0.00% 3 Missing ⚠️
...Settings/NetworksSettings/NetworkSettings/index.js 0.00% 3 Missing ⚠️
...omponents/Views/Settings/NetworksSettings/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12843      +/-   ##
==========================================
+ Coverage   59.72%   59.78%   +0.05%     
==========================================
  Files        1865     1871       +6     
  Lines       42011    42124     +113     
  Branches     5458     5469      +11     
==========================================
+ Hits        25093    25183      +90     
- Misses      15239    15258      +19     
- Partials     1679     1683       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@salimtb salimtb requested review from a team as code owners January 9, 2025 10:19
@salimtb salimtb force-pushed the fix/improve-network-switch-perf branch from b1d930b to 3787621 Compare January 9, 2025 10:23
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c57cdf8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f00b991-3abd-4e23-a31b-8809d9a1d702

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 82bb345
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/388406a9-294e-497f-8d4e-32ef3fcbf8a1

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 79c000e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/99ade033-dd3d-400e-a9b2-49f4456eacb0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d287b7e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5399f05e-8e13-4960-9779-873ddc5072e9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5689064
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12c53c59-3c69-48a1-9232-afff509a9c95

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4742e69
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54765c82-45ec-4109-92a3-5921897e1296

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

@chrisleewilcox chrisleewilcox chrisleewilcox requested changes

@vinnyhoward vinnyhoward vinnyhoward left review comments

@Prithpal-Sooriya Prithpal-Sooriya Awaiting requested review from Prithpal-Sooriya

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Status: Needs more work from the author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Slower performance when selecting tokens on a network different from the one currently active
8 participants
@salimtb @codecov-commenter @owencraston @chrisleewilcox @Prithpal-Sooriya @matthewwalsh0 @vinnyhoward @metamaskbot